Skip to content

fix(oracle): fix changeColumn SQL for BLOB to avoid implicit conversion #17719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

hjamil-24
Copy link

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

For BLOB, changeColumnQuery() tries to convert Datatypes implicitly. This leads to failure.
For example: During sequelize.sync({alter: true}) alters column with implicit datatype conversion from long to Blob.

List of Breaking Changes

@hjamil-24 hjamil-24 changed the title Change column fix(oracle): fix changeColumn SQL for BLOB to avoid implicit conversion Feb 17, 2025
@WikiRik
Copy link
Member

WikiRik commented Feb 26, 2025

I hope to fix Node 10 support in #17724 so we can merge this after

@WikiRik WikiRik added the v6 label Mar 9, 2025
@WikiRik WikiRik merged commit 5b7c801 into sequelize:v6 Mar 28, 2025
49 of 53 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.37.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants