Reviewing files that changed from the base of the PR and between fc45403 and 9c9ef61.

• shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/advancedFilterButton.tsx (3 hunks)
• shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/advancedFilterButtonComponent.tsx (3 hunks)
• shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/settingsForm.ts (1 hunks)
• shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/style.ts (2 hunks)

• GitHub Check: build-attempt

shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/advancedFilterButton.tsx (3)

2-2: LGTM! Tooltip import added correctly.

The Tooltip import from 'antd' is properly added to support the new tooltip functionality.

---

19-19: LGTM! useStyles call simplified correctly.

The change from passing an object {fontSize: props.styles?.fontSize} to directly passing props.styles?.fontSize aligns with the updated function signature in style.ts. This simplification improves readability.

---

72-90: LGTM! Tooltip implementation is correct.

The Button component is properly wrapped with the Tooltip component, and the tooltip text is correctly sourced from props.tooltip. This enhances user experience by providing contextual help.

shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/style.ts (2)

3-3: LGTM! Function signature simplification improves API design.

Changing from destructured object parameter {fontSize} to direct parameter fontSize: string | number simplifies the API and makes the function more straightforward to use. The type annotation is appropriate.

---

37-37: LGTM! CSS formatting maintained.

The indentation adjustment maintains code consistency without affecting functionality.

shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/advancedFilterButtonComponent.tsx (3)

1-9: LGTM! Import cleanup improves maintainability.

The import statements have been properly reorganized and unused imports (QuestionCircleOutlined, Show, Tooltip) have been removed. This reduces bundle size and improves code clarity.

---

17-20: LGTM! Factory rendering simplified appropriately.

The removal of the wrapping <div> and conditional tooltip logic is correct since the tooltip functionality has been moved into the AdvancedFilterButton component itself. This simplifies the component structure.

---

32-33:

❓ Verification inconclusive

Verify the migration version number changes.

The migration version numbers were changed from 3 and 4 to 1 and 2. Ensure this change is intentional and doesn't break existing migration paths.

---

🏁 Script executed:

#!/bin/bash
# Description: Check for other migration references to understand the versioning strategy
# Expected: Find other migration configurations to understand the versioning pattern

echo "Searching for migration version patterns in the codebase..."
rg -A 3 -B 3 "\.add<.*>\([0-9]+," --type ts

Length of output: 323

---

🏁 Script executed:

#!/bin/bash
# Description: Search for all .add<…>(version,…) calls across TS and TSX files
echo "Scanning for migration steps in .ts and .tsx files…"
rg "\.add<[^>]+>\([0-9]+," -n -g "*.ts" -g "*.tsx"

Length of output: 314

---

Verify Migration Version Numbers

I searched the entire codebase for other .add<…>(version, …) calls but didn’t find any additional migration steps. Please confirm that resetting these steps to versions 1 and 2 here is intentional and won’t conflict with any existing migration history.

• Location: shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/advancedFilterButtonComponent.tsx lines 32–33

shesha-reactjs/src/designer-components/dataTable/advancedFilterButton/settingsForm.ts (1)

662-669: LGTM! Permission input standardized.

The change from addPermissionAutocomplete to addSettingsInput with inputType: 'permissions' appears to be a standardization effort. This approach provides consistency with other form inputs while maintaining the same functionality.