Skip to content

🛂(frontend) Restore version visibility #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Feb 11, 2025

Purpose

When you are a reader member, you have the right to see the version but you cannot restore them.
So, we hide the restore button when you are a reader.

Proposal

  • 🩹(docker-compose) remove comment
  • 🛂(frontend) hide version restore button when reader

Where

image

@AntoLC AntoLC self-assigned this Feb 11, 2025
@AntoLC AntoLC force-pushed the fix/restore-version-visibility branch from 44f6d5c to 7b88ccf Compare February 11, 2025 14:53
@AntoLC AntoLC requested a review from lunika February 11, 2025 14:58
@@ -15,7 +15,7 @@ services:
- "1081:1080"

minio:
# user: ${DOCKER_USER:-1000}
user: ${DOCKER_USER:-1000}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already modified in main branch

When you are a reader member, you have the right to
see the version but you cannot restore
them. So, we hide the restore button
when you are a reader.
@AntoLC AntoLC force-pushed the fix/restore-version-visibility branch from 7b88ccf to 18c4dca Compare February 18, 2025 08:19
@AntoLC AntoLC enabled auto-merge (rebase) February 18, 2025 08:20
@AntoLC AntoLC merged commit aefbc2e into main Feb 18, 2025
18 checks passed
@AntoLC AntoLC deleted the fix/restore-version-visibility branch February 18, 2025 08:30
@AntoLC AntoLC mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants