Skip to content

🐛(backend) allow more extensions for media download #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

sampaccoud
Copy link
Member

Purpose

A user reported that mp4 video were not working.
The request to download the video is getting a 403 whereas images work on the same document 🤔

Proposal

The regex to validate media file extensions was too restrictive. Make it more permissive to allow any type of file extensions.

@sampaccoud sampaccoud requested a review from AntoLC March 1, 2025 10:52
@sampaccoud sampaccoud self-assigned this Mar 1, 2025
@sampaccoud sampaccoud added bug Something isn't working python Pull requests that update Python code backend urgent labels Mar 1, 2025
The regex to validate media file extensions was too restrictive.
@sampaccoud sampaccoud force-pushed the allow-media-extensions-with-digits branch from f689d31 to 1e97b4b Compare March 1, 2025 10:54
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising we didn't see that before.

@sampaccoud sampaccoud merged commit ef21275 into main Mar 3, 2025
18 of 19 checks passed
@sampaccoud sampaccoud deleted the allow-media-extensions-with-digits branch March 3, 2025 10:21
@AntoLC AntoLC mentioned this pull request Mar 3, 2025
@AntoLC AntoLC linked an issue Mar 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working python Pull requests that update Python code urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many file type not accepted as upload
2 participants