Skip to content

✨Add divider #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

✨Add divider #698

merged 2 commits into from
Mar 14, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Mar 10, 2025

Purpose

Add a divider in the editor.

Proposal

  • ✨(frontend) add divider blocks to the editor
  • ✨(frontend) adapt export to divider block

Demo

scrnli_pCdmkyoMeEQS2d.webm

PDF

image

DocX

image

@AntoLC AntoLC added frontend feature add a new feature editor labels Mar 10, 2025
@AntoLC AntoLC self-assigned this Mar 10, 2025
@AntoLC AntoLC force-pushed the feature/add-divider branch from 58bbeb4 to 4a89597 Compare March 11, 2025 11:24
@AntoLC AntoLC marked this pull request as ready for review March 11, 2025 11:29
@AntoLC AntoLC requested a review from NathanVss March 11, 2025 11:30
@AntoLC AntoLC linked an issue Mar 11, 2025 that may be closed by this pull request
1 task
AntoLC added 2 commits March 13, 2025 17:40
Add a custom block to add a divider in the editor.
We have a new block type, the divider block.
We have to adapt the export to handle this
new block type.
@AntoLC AntoLC force-pushed the feature/add-divider branch from 4a89597 to 0afcf1a Compare March 13, 2025 16:40
Copy link
Contributor

@NathanVss NathanVss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) !

@AntoLC AntoLC merged commit 4316b4e into main Mar 14, 2025
16 of 19 checks passed
@AntoLC AntoLC deleted the feature/add-divider branch March 14, 2025 09:39
@AntoLC AntoLC mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add divider as block type
2 participants