🐛(frontend) SVG export #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 12, 2025
AntoLC
force-pushed
the
fix/svg-export
branch
2 times, most recently
from
048a534 to
a965fae
Compare
NathanVss
approved these changes
Mar 14, 2025
The svg was not rendering in the pdf export. We overwrite the default mapping to convert the svg to png before rendering. The images could be out of the page as well, we fixed this issue by adding a maxWidth to the image.
The svg was not rendering in the dox export. We overwrite the default mapping to convert the svg to png before rendering. The images could be out of the page as well, we fixed this issue by adding a maxWidth to the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The SVG were not displayed in the export (PDF / Docx).
Proposal
We convert the SVG to PNG before exporting.
Images could be out of the container, we added a max width.