🐛(backend) fix postgres healthcheck #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameroncking
changed the title
|
Hi @cameroncking , Thank you very much for your contribution, we appreciate it. And it was something we planned to fix so your contribution is more than welcome. I let you squash your commit and rename it following our convention https://suitenumerique.gitbook.io/handbook/git#type-scope-and-subject |
cameroncking
force-pushed
the
main
branch
2 times, most recently
from
62bccfc to
ff0df0c
Compare
|
I believe I have updated the commit message correctly. Thank you for the quick review! |
|
Almost done, The last line in your commit body is too long:
Going to a new line after the word |
cameroncking
force-pushed
the
main
branch
2 times, most recently
from
50da03c to
05294fe
Compare
Adds PostgreSQL user and database names to the docker-compose.yaml healthchecks. This resolves an error that appears in the logs, where 'root' is used by default.
lunika
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Today, the docker healthcheck does not include the postgreql user or database name. This causes errors such as the following:
Proposal
Update the
pg_isreadycommand to specify the username and password such aspg_isready -d $${POSTGRES_DB} -U $${POSTGRES_USER}.See also:
Test
After applying this fix, the error message mentioned above no longer appears in
docker compose logs -f.