♻️(documents) inherit manager from queryset #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
commented
Mar 24, 2025
src/backend/core/models.py
Outdated
| """ | ||
| return self.get_queryset().readable_per_se(user) | ||
| """Sets the custom queryset as the default.""" | ||
| return self._queryset_class(self.model).order_by('path') |
There was a problem hiding this comment.
See
class MP_NodeManager(models.Manager):
"""Custom manager for nodes in a Materialized Path tree."""
def get_queryset(self):
"""Sets the custom queryset as the default."""
return MP_NodeQuerySet(self.model).order_by('path')
qbey
force-pushed
the
qbey/document-manager-simple
branch
from
dedbb5e to
b866bb7
Compare
|
I suggest to inherit from If it's ok to mix the "django way" and what they made, I agree to merge this PR. |
lunika
approved these changes
Mar 24, 2025
During a code review, I saw we are overriding the MP_NodeManager and redefine the queryset filters: - The MP_NodeManager sorts the queryset by `path` by default and it's not done on our side, is it on purpose? - The fact we need to redefine `readable_per_se` as a boilerplate is surprising. I suggest we use the Django mechanism to generate the manager from the queryset.
lunika
force-pushed
the
qbey/document-manager-simple
branch
from
b866bb7 to
27aa7c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During a code review, I saw we are overriding the MP_NodeManager and redefine the queryset filters:
pathby default and it's not done on our side, is it on purpose?readable_per_seas a boilerplate is surprising.Proposal
I suggest we use the Django mechanism to generate the manager from the queryset.
from_querysetclass method to generate the document manager.