🔧(backend) configurable footer #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
force-pushed
the
backend/footer-configurable
branch
2 times, most recently
from
9c19d91 to
d6fa2b8
Compare
We added the `FRONTEND_URL_JSON_FOOTER` environment variable. It will give the possibility to generate your own footer content in the frontend. If the variable is not set, the footer will not be displayed.
We move the cache reset in the global conf test to not have to think about reseting the cache when we implement test.
AntoLC
force-pushed
the
backend/footer-configurable
branch
from
1972ef4 to
087eca3
Compare
AntoLC
changed the title
AntoLC
force-pushed
the
backend/footer-configurable
branch
from
087eca3 to
9054cf8
Compare
lunika
approved these changes
Apr 4, 2025
env.d/development/common.dist
Outdated
| @@ -63,5 +63,6 @@ COLLABORATION_SERVER_SECRET=my-secret | |||
| COLLABORATION_WS_URL=ws://localhost:4444/collaboration/ws/ | |||
|
|
|||
| # Frontend | |||
| FRONTEND_FOOTER_FEATURE_ENABLED=True | |||
There was a problem hiding this comment.
Add it line 67 to group with FRONTEND_URL_JSON_FOOTER ?
We added the feature flag `FRONTEND_FOOTER_FEATURE_ENABLED` to enable or disable the footer in the frontend.
AntoLC
force-pushed
the
backend/footer-configurable
branch
from
9054cf8 to
f03784b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposal
FRONTEND_FOOTER_FEATURE_ENABLEDenvironment variable, a feature flag to enable or not the footer.FRONTEND_URL_JSON_FOOTERenvironment variable. It will give the possibility to generate your own footer content in the frontend.Structure content footer:
https://github.com/suitenumerique/docs/blob/1972ef4d07eb2be2b7b0ac901b00ac8ffc8b9d7f/src/frontend/apps/impress/public/contents/footer-demo.json