♻️(frontend) bind ui with ability access #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/ability-access
branch
from
5021c62 to
091e485
Compare
AntoLC
force-pushed
the
refacto/ability-access
branch
2 times, most recently
from
12785ec to
5d0a01b
Compare
lunika
reviewed
Apr 28, 2025
| @@ -79,7 +79,7 @@ test.describe('Doc Export', () => { | |||
| }) | |||
| .click(); | |||
|
|
|||
| await page | |||
| void page | |||
There was a problem hiding this comment.
I didn't know it is possible to do that. It is not the same to remove await without void ? What means the usage of void here ?
There was a problem hiding this comment.
We have this rule in place: https://typescript-eslint.io/rules/no-floating-promises/
Placing the void operator in front of a Promise can be a convenient way to explicitly mark that Promise as intentionally not awaited.
So yes, it is the same to remove await without void but with a nuance, by adding void we signified to the linter that we are aware that it is a promise but that we want to just let it go (without then or await).
lunika
approved these changes
Apr 30, 2025
Some actions were not available in the frontend but allowed in the backend, this commit binds the frontend ui with the ability access coming from the backend.
AntoLC
force-pushed
the
refacto/ability-access
branch
from
5d0a01b to
9ca7968
Compare
This was referenced May 2, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some actions were not available in the frontend but allowed in the backend.
Proposal
We bind the UI with the ability access coming from the backend.