🏗️(frontend) footer configurable #959
Conversation
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
13b6929 to
24febb9
Compare
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
24febb9 to
f1d2050
Compare
AntoLC
changed the title
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
98267cd to
027bdf9
Compare
| "logo": { | ||
| "src": "/assets/icon-docs.svg", | ||
| "width": "54px", | ||
| "alt": "Docs Logo", |
There was a problem hiding this comment.
How about we consider a more direct approach for translating strings?
If we used translation slugs instead of plain text:
-
It could simplify things by removing the need for
default,fr,enand similar sub-keys. -
It would also alleviate the burden of updating the full theme configuration when a new language is added, a process currently more involved than maintaining a flat JSON for translations.
-
This shift would also enhance modularity and better separate responsibilities.
-
It would allow translators of crowdin to properly translate the default values.
-
It would reduce the size of the theming file significantly - potentially improving payload transfer speed and overall reactivity of the app
-
It would allow nested translations to be integrated in the future, further reducing complexity and improving flexibility
There was a problem hiding this comment.
Until we cannot override translations per instance we cannot do this way.
But I think you're right, we should refacto this part as soon we can override translations, I will open an issue about it.
| <IconLink width={18} /> | ||
| </StyledLink> | ||
| </Text> | ||
| {bottomInformation.label}{' '} |
There was a problem hiding this comment.
not a big to add a space like this
There was a problem hiding this comment.
It is rewrote like that by prettier.
AntoLC
force-pushed
the
refacto/footer-from-json
branch
2 times, most recently
from
ae05629 to
8494fd9
Compare
The rule @typescript-eslint/no-unused-vars didn't have a ignore pattern. A ignore pattern can be usefull in some cases.
Improve config testcases: - let THEME_CUSTOMIZATION_FILE_PATH to be set to check the default value - add helper function overrideConfig
To have different footer per instance the content of the footer is now configurable from the theme customization file. See THEME_CUSTOMIZATION_FILE_PATH env var.
Legal pages are not needed anymore in the application. In the dsfr instances, the legal pages will be displayed on a Docs pages. We let the users of Docs managing the legal pages on their own instances.
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
8494fd9 to
7a38395
Compare
Purpose
We need to have different footer per instance.
The footer has to be displayable or not.
Proposal
Bind the frontend footer with the theme configuration file:
https://github.com/suitenumerique/docs/blob/main/src/backend/impress/configuration/theme/default.json
Demo