Skip to content

Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Apr 26, 2025

There is a ZPP arginfo violation because the empty return or error return is not always properly handled.
And there is also a memory leak if creating the regular expression instance fails.

Found with help of an experimental SA I'm developing.

…Pattern

There is a ZPP arginfo violation because the empty return or error
return is not always properly handled.
And there is also a memory leak if creating the regular expression
instance fails.
@nielsdos nielsdos closed this in 2eb3100 Apr 27, 2025
nielsdos added a commit that referenced this pull request Apr 27, 2025
* PHP-8.3:
  datefmt_parse/datefmt_localtime references type system fixes
  Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern
nielsdos added a commit that referenced this pull request Apr 27, 2025
* PHP-8.4:
  Fix IntlDateFormatter::parseToCalendar() reference type system breaks
  datefmt_parse/datefmt_localtime references type system fixes
  Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants