[build]: Add rt_base_image parameter to differentiate triton build base image and runtime base image #8064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0a5d2f.
nv-tusharma
force-pushed
the
tusharma/cuda-runtime-base
branch
from
3b82608 to
741135a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add new image argument (--rt_base) which if passed in, is used as the final base image for the triton executable. This allows users to pass in their own final base image to host the triton server executable.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Where should the reviewer start?
build.py
Test plan:
Validated existing CI tests pass with change
CI Pipeline ID:
25249521
Caveats:
Background
Container Image Size reduction