Tasks related to JavaScript in MediaWiki core or extensions.
See also Instrument-ClientError (Javascript error logging in Wikimedia production).
Tasks related to JavaScript in MediaWiki core or extensions.
See also Instrument-ClientError (Javascript error logging in Wikimedia production).
In T381537#10904771, @Escargot_rouge wrote:When using await without an async in the onwiki code editor, we get an error: Missing ";" before statement. which is unhelpful in understanding the issue.
Looks like Safari 16.4 was released on March 27, 2023. Yeah, that is a bit of a problem in terms of delaying this ticket. It could be many years before it makes sense for us to drop grade A support for Safari <16.4.
In T395347#10904522, @Tacsipacsi wrote:(Do Peast and ESLint support such a hybrid approach?)
When using await without an async in the onwiki code editor, we get an error: Missing ";" before statement. which is unhelpful in understanding the issue.
Given that regex stuff requires dropping support for that many Safari versions, is it maybe possible to allow all ES2018 features except for the regex ones? (Do Peast and ESLint support such a hybrid approach?) I personally use the spread operator outside of MediaWiki all the time, but hardly ever do I use advanced regex features.
In T395347#10882608, @Xeverything11 wrote:ES2018 RegEx features require Safari 12+, so we have to increase Grade A Safari requirement from 11.1 to at least 12 before implementing ES2018.
Change #1155308 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Use browser native URL instead of mw.Uri
In T374314#10901308, @simon04 wrote:
- MediaWiki core (8 files) – excluding mw.Uri itself and documentation
- resources/src/mediawiki.api/index.js (1 matches) – only in code comment
- resources/src/mediawiki.feedback/feedback.js (1 matches) – only in jsdoc
- mediawiki/extensions/CentralAuth (2 files) – false positive matches (only in jsdoc)
- modules/ext.centralauth.ForeignApi.js (1 matches)
- modules/ext.centralauth.ForeignRest.js (1 matches)
Change #1155308 had a related patch set uploaded (by Simon04; author: Simon04):
[mediawiki/extensions/WikiLambda@master] Use browser native URL instead of mw.Uri
Change #1143631 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@master] Use browser native URL instead of mw.Uri
Assuming that the scope of this task is just extensions deployed on Wikimedia wikis, it looks like it's almost done. Everything listed in the description is resolved, but I did some more code-searching and found a few more results that were missed (or perhaps were added in the meantime). I'll update it, we'll fix them, and then I think this can be closed.
Thank you for the explanation. The USERJSPARSE_CACHE_VERSION is simply located in /includes/ResourceLoader/Module.php.
Change #1151742 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use browser native URL instead of mw.Uri
Change #1119875 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/Flow@master] Change deprecated use of mw.Uri
Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/1151742 – sorry!
The Peast call is behind a memcached key by (wiki, page title, revision hash).
If Wikimedia is upgraded to ES2017 except for the edge case mentioned in the two comments above, we might want to resolve this ticket, then document that issue in a separate ticket. Thoughts on copy pasting those two comments into a new ticket and dropping a link here?
Interestingly, a user resolved the issue by modifying the relevant script to force a server-side refresh. However, it seems problematic that such an intervention was necessary. Is there a way to enhance the process to avoid this workaround?
We have an issue on frwiki. Although we have been updated to 1.45.0-wmf.4 as expected, we are encountering this error:
Not sure if Krinkle's suggestion should be handled in this task or a new task. Will re-open this one for now to help draw attention.
The rest of the Notification class docs are still missing (classdesc, start, pause, resume, close) from the web page.
Looks fixed
Change #1136017 merged by jenkins-bot:
[mediawiki/core@master] docs: Make internal Notification object visible on docs site
Safari 11.1 (macOS) and 11.3-11.4 (iOS) only account for 0.02% of market share, according to CanIUse.
ES2018 RegEx features require Safari 12+, so we have to increase Grade A Safari requirement from 11.1 to at least 12 before implementing ES2018.
Cannot reproduce, nor similar logs in Logstash.