The Wayback Machine - https://web.archive.org/web/20210815013714/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1240
Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive implementation of Bubble sort #1240

Closed
wants to merge 4 commits into from
Closed

Recursive implementation of Bubble sort #1240

wants to merge 4 commits into from

Conversation

@Krishnapal4050
Copy link
Contributor

@Krishnapal4050 Krishnapal4050 commented Oct 10, 2020 •
edited by gitpod-io bot

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

github-actions and others added 3 commits Oct 10, 2020
github-actions github-actions
updating DIRECTORY.md
29074e7
@Krishnapal4050
Recursive Bubble sort implementation
6372730
github-actions github-actions
updating DIRECTORY.md
cc3f1a7
@Krishnapal4050
Copy link
Contributor Author

@Krishnapal4050 Krishnapal4050 commented Oct 10, 2020 •
edited

@kvedala As suggested by you, when I rebased that branch, that pull request got closed automatically. So, I had to create a new PR after rebasing this branch.
Please review it now and give your valuable suggestions.
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

👍
Please review the contribution guidelines. Especially: https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#typical-structure-of-a-program
and update the code before the review. Thank you
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

You can also review the existing code: https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/sorting/insertion_sort.cpp for reference.
@Panquesito7
Panquesito7 requested changes Oct 12, 2020
View changes
sorting/recursive_bubble_sort.cpp Outdated Show resolved Hide resolved
sorting/recursive_bubble_sort.cpp
}


int main()

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 12, 2020
Member
Suggested change
int main()
/**
* @brief Main function
* @returns 0 on exit
*/
int main()

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 15, 2020
Member

Not resolved/fixed yet.

sorting/recursive_bubble_sort.cpp
#include<iostream>
#include <array>

void recBubble(std::array<int,10> arr, int n){

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 12, 2020
Member

Missing function documentation.

DIRECTORY.md
@@ -113,7 +113,9 @@
* [Adaline Learning](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/adaline_learning.cpp)
* [Kohonen Som Topology](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_topology.cpp)
* [Kohonen Som Trace](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_trace.cpp)
* [Neural Network](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/neural_network.cpp)

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 12, 2020
Member

I don't know why is this being added, but I think it should be removed.

@Krishnapal4050 @Panquesito7
Update sorting/recursive_bubble_sort.cpp
6a9cdf9 
Co-authored-by: David Leal <[email protected]>
@github-actions github-actions bot force-pushed the Krishnapal4050:bubble-sort branch from f4a7df9 to 6a9cdf9 Oct 13, 2020
@aadijay3477
aadijay3477 reviewed Oct 15, 2020
View changes
DIRECTORY.md
* [Adaline Learning](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/adaline_learning.cpp)
* [Kohonen Som Topology](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_topology.cpp)
* [Kohonen Som Trace](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_trace.cpp)
* [Neural Network](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/neural_network.cpp)
Comment on lines 113 to +116

This comment has been minimized.

Sign in to view
@aadijay3477

aadijay3477 Oct 15, 2020

Needs a review i think it's irrelevant.

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 15, 2020
Member

Those changes were made by the GitHub Actions itself.
AFAIK, if we revert those changes, they will be made automatically again.

@Panquesito7 Panquesito7 added this to List to Fix in Good First Issues Jun 18, 2021
@stale
Copy link

@stale stale bot commented Jun 30, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the abandoned label Jun 30, 2021
@stale
Copy link

@stale stale bot commented Jul 30, 2021

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!
@stale stale bot closed this Jul 30, 2021
Good First Issues automation moved this from List to Fix to Completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadijay3477 aadijay3477

@Panquesito7 Panquesito7

Assignees
No one assigned
Labels
abandoned awaiting modification enhancement good first issue hacktoberfest Proper Documentation Required requested changes
Projects
Good First Issues
  
Completed
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Krishnapal4050 @kvedala @aadijay3477 @Panquesito7