[8.x] Rename test methods #5574
Merged
+2
−2
Conversation
imabug
added a commit
to imabug/raddb
that referenced
this pull request
Mar 27, 2021
keljtanoski
added a commit
to keljtanoski/laravel
that referenced
this pull request
Mar 31, 2021
Rename test methods (laravel#5574)
imabug
added a commit
to imabug/raddb2
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We decided a while back to go for snake case as our convention for methods names in tests. All of our other first party libraries except for the framework are already on this convention. This PR moves the skeleton to the same convention. We'll convert the framework as well at some point.
Note that these new method names reflect the ones from the stub files in the framework when scaffolding a test using
make:test. This also removes the duplicate "test" word.