The Wayback Machine - https://web.archive.org/web/20210921100708/https://github.com/cube-js/cube.js/pull/3430
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): transform content headers to links #3430

Merged
merged 4 commits into from Sep 17, 2021

Conversation

@YakovlevCoded
Copy link
Member

@YakovlevCoded YakovlevCoded commented Sep 15, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@YakovlevCoded YakovlevCoded requested a review from cube-js/developer-relations-and-community as a code owner Sep 15, 2021
@YakovlevCoded YakovlevCoded requested review from igorlukanin and rchkv Sep 15, 2021
Copy link
Member

@igorlukanin igorlukanin left a comment

@YakovlevCoded, LGTM but — I don't think this should be merged as fix(docs) (maybe chore(docs?) because it will then appear in the changelog.

@YakovlevCoded YakovlevCoded changed the title fix(docs): transform content headers to links chore(docs): transform content headers to links Sep 17, 2021
@YakovlevCoded YakovlevCoded merged commit 2f85136 into master Sep 17, 2021
3 checks passed
3 checks passed
@github-actions
Build
Details
@netlify
netlify/cubejs-docs-staging/deploy-preview Deploy Preview ready!
Details
security/snyk (cube-js) No manifest changes detected in 44 projects
Details
@YakovlevCoded YakovlevCoded deleted the leonid-yakovlev-headers-link branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants