The Wayback Machine - https://web.archive.org/web/20221223155258/https://github.com/python/cpython/pull/28573
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45113: Add PyStructSequence_FromModuleAndDesc() to create a new struct sequence type. #28573

Closed
wants to merge 4 commits into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Sep 26, 2021

@shihai1991 shihai1991 requested a review from a team as a code owner Sep 26, 2021
@shihai1991 shihai1991 force-pushed the bpo_45113_3 branch 2 times, most recently from 1d033a4 to 0cdbd11 Compare Sep 27, 2021
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Looks good to me!

Objects/structseq.c Outdated Show resolved Hide resolved
@shihai1991 shihai1991 requested a review from encukou Oct 7, 2021
@shihai1991
Copy link
Member Author

shihai1991 commented Oct 7, 2021

Hi, Petr. Would you mind to take a look? @encukou
PyType_FromSpecWithBases() allocates tp_members when I call this function. So I think the tp_members of struct sequence can be maintained.

Objects/structseq.c Outdated Show resolved Hide resolved
Objects/structseq.c Outdated Show resolved Hide resolved
Objects/structseq.c Outdated Show resolved Hide resolved
shihai1991 added 2 commits Oct 21, 2021
* main: (263 commits)
  bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051)
  bpo-45522: Allow to disable freelists on build time (pythonGH-29056)
  bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105)
  bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110)
  bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103)
  bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331)
  bpo-44174: [Enum] add reference to name mangling (pythonGH-29116)
  bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115)
  bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049)
  bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323)
  bpo-45527: Don't count cache hits, just misses. (pythonGH-29092)
  bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618)
  bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649)
  bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100)
  bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094)
  Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079)
  bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088)
  Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097)
  Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085)
  bpo-44525: Specialize simple Python calls. (pythonGH-29033)
  ...
@shihai1991 shihai1991 requested review from encukou and tiran Oct 23, 2021
@shihai1991
Copy link
Member Author

shihai1991 commented Jan 19, 2022

Thanks for review this PR. I close this PR as Petr said in https://bugs.python.org/issue45113#msg406408.

@shihai1991 shihai1991 closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants