The Wayback Machine - https://web.archive.org/web/20220203064450/https://github.com/python/cpython/pull/28030
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41620: TestCase.run() now always return a TestResult instance #28030

Merged
merged 1 commit into from Aug 30, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 29, 2021

Previously it returned None if the test class or method was
decorated with a skipping decorator.

https://bugs.python.org/issue41620

Previously it returned None if the test class or method was
decorated with a skipping decorator.
Copy link
Member

@iritkatriel iritkatriel left a comment

LGTM. Would be nice to include Iman as co-author.

@ambv ambv merged commit 7e246a3 into python:main Aug 30, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 30, 2021

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 30, 2021
…thonGH-28030)

Previously it returned None if the test class or method was
decorated with a skipping decorator.

Co-authored-by: Iman Tabrizian <[email protected]>
(cherry picked from commit 7e246a3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 30, 2021

GH-28064 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 30, 2021

GH-28065 is a backport of this pull request to the 3.9 branch.

@ambv
Copy link
Contributor

@ambv ambv commented Aug 30, 2021

I credited Iman in the commit message.

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 30, 2021
…thonGH-28030)

Previously it returned None if the test class or method was
decorated with a skipping decorator.

Co-authored-by: Iman Tabrizian <[email protected]>
(cherry picked from commit 7e246a3)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this issue Aug 30, 2021
…-28030) (GH-28065)

Previously it returned None if the test class or method was
decorated with a skipping decorator.

Co-authored-by: Iman Tabrizian <[email protected]>
(cherry picked from commit 7e246a3)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this issue Aug 30, 2021
…-28030)

Previously it returned None if the test class or method was
decorated with a skipping decorator.

Co-authored-by: Iman Tabrizian <[email protected]>
(cherry picked from commit 7e246a3)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants