CI Use lock file for CircleCI arm64 build #23392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
May 18, 2022
LGTM, I like how those PRs are progressively remove logics from the CI-specific test scripts to get a more uniform CI environment.
thomasjpfan
reviewed
May 18, 2022
Thanks for the PR. In general, this is much cleaner. Now that build_tools/azure/update_environments_and_lock_files.py is moved to build_tools/update_environments_and_lock_files.py, there are a few references to update:
git grep -n build_tools/azure/update_environments_and_lock_filesResult
build_tools/azure/debian_atlas_32bit_requirements.txt:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/py38_conda_defaults_openblas_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/py38_conda_forge_openblas_ubuntu_1804_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_conda_forge_mkl_linux-64_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_conda_forge_mkl_no_coverage_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_conda_forge_mkl_osx-64_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_conda_mkl_no_openmp_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_pip_openblas_pandas_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pylatest_pip_scipy_dev_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/pypy3_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/azure/ubuntu_atlas_requirements.txt:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/circle/py39_conda_forge_environment.yml:3:# build_tools/azure/update_environments_and_lock_files.py
build_tools/update_environments_and_lock_files.py:4:python build_tools/azure/update_environments_and_lock_files.py
build_tools/update_environments_and_lock_files.py:313:# build_tools/azure/update_environments_and_lock_files.py
build_tools/update_environments_and_lock_files.py:378:# build_tools/azure/update_environments_and_lock_files.py
|
Thanks @lesteve First time that I look at the system. This is super nice. Great works. The CI will never fail again ;) |
lesteve
added a commit
to lesteve/scikit-learn
that referenced
this issue
May 19, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
part of #22425.
This switches the CircleCI arm64 build to lock file.
Main changes:
build_test_arm.shand.circle/config.ymlupdate_environment_and_lock_files.pytobuild_tools(before was inbuild_tools/azure)foldertobuild_metatadata(build_tools/azurevsbuild_tools/circle)