The Wayback Machine - https://web.archive.org/web/20221031025252/https://github.com/symfony/symfony/pull/45931
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Process] Fix Process::getEnv() when setEnv() hasn't been called before #45931

Merged
merged 1 commit into from Apr 4, 2022
Merged

[Process] Fix Process::getEnv() when setEnv() hasn't been called before #45931

merged 1 commit into from Apr 4, 2022

Conversation

asika32764
Copy link
Contributor

@asika32764 asika32764 commented Apr 4, 2022 •
edited by nicolas-grekas

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT

AS getEnv() return type is array, if a Process object has no default env and is NULL value, calling getEnv() will get error.

$process = $someObject->createProcess(); // Get process from some object, but we don't know the environment

// We want to check the env
$env = $process->getEnv(); // Error: return type must be array, NULL given.

@carsonbot carsonbot added this to the 6.1 milestone Apr 4, 2022
@carsonbot
Copy link

carsonbot commented Apr 4, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@asika32764 asika32764 changed the base branch from 6.1 to 6.0 Apr 4, 2022
@asika32764 asika32764 changed the base branch from 6.0 to 6.1 Apr 4, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 4.4 Apr 4, 2022
nicolas-grekas
nicolas-grekas reviewed Apr 4, 2022
View changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Good catch.
I think it might be better to initialize the property to the empty array, then we wouldn't have to patch this method.
Also, since this is a bugfix, it should target 4.4, and should have a test case. Can you add one please? (I can handle the re-targeting while merging)

@asika32764
Copy link
Contributor Author

asika32764 commented Apr 4, 2022

Sorry I have heavy work on my job, so I'm afraid that I'm not available to do future works.

Just fix it thought your standard way, thanks.

@carsonbot carsonbot changed the title Make Process::getEnv() default return array if is NULL [Process] Make Process::getEnv() default return array if is NULL Apr 4, 2022
@nicolas-grekas nicolas-grekas changed the title [Process] Make Process::getEnv() default return array if is NULL [Process] Fix Process::getEnv() when setEnv() hasn't been called before Apr 4, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.1 to 4.4 Apr 4, 2022
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 4, 2022

Thanks @asika32764.

@nicolas-grekas nicolas-grekas merged commit 81c9e39 into symfony:4.4 Apr 4, 2022
9 of 10 checks passed
This was referenced Apr 27, 2022
Merged
Merged
Merged
Reviewers

@nicolas-grekas nicolas-grekas

@xabbuh xabbuh

@lyrixx lyrixx

@dunglas dunglas

@yceruto yceruto

@wouterj wouterj

@chalasr chalasr

@OskarStark OskarStark

@jderusse jderusse

Assignees
No one assigned
Labels
Bug Process Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asika32764 @carsonbot @nicolas-grekas