Allow the Slider to always show the value indicator. #162223

yiiim · 2025-01-26T09:21:10Z

Modified enum ShowValueIndicator
before:

enum ShowValueIndicator {
  onlyForDiscrete,
  onlyForContinuous,
  always,
  never,
}

after:

enum ShowValueIndicator {
  onlyForDiscrete,
  onlyForContinuous,
  @Deprecated(
    'Use ShowValueIndicator.onDrag. '
    'This feature was deprecated after v3.28.0-1.0.pre.',
  )
  always,
  onDrag,
  alwaysVisible,
  never,
}

To maintain previous behavior, ShowValueIndicator.onlyForDiscrete and ShowValueIndicator.onlyForContinuous are still retained.

The behavior of ShowValueIndicator.always remains consistent with the previous implementation, but it is marked as deprecated and should be replaced with ShowValueIndicator.onDrag. A new ShowValueIndicator.alwaysVisible has been added to show the value indicator even when not dragging.

Additionally, the value indicator is now rendered by OverlayPortal.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks

Thanks for another PR @yiiim!
FYI @TahaTesser who is verry familiar with sliders. :)

packages/flutter/lib/src/material/range_slider.dart

packages/flutter/lib/src/material/slider_theme.dart

packages/flutter/test/material/range_slider_test.dart

packages/flutter/lib/src/material/range_slider.dart

TahaTesser

This PR does a fair bit of refactoring to add OverlayPortal, this makes sliders more complex.

We had previous show value indicator behaviors without OverlayPortal. Please provide more details on OverlayPortal addition and benefits.

packages/flutter/lib/src/material/range_slider.dart

yiiim · 2025-02-17T14:38:16Z

This PR does a fair bit of refactoring to add OverlayPortal, this makes sliders more complex.

We had previous show value indicator behaviors without OverlayPortal. Please provide more details on OverlayPortal addition and benefits.

Now, when ShowValueIndicator changes, it is necessary to update the child on the overlay simultaneously. OverlayPortal can easily achieve this.

And when we change ShowValueIndicator through setState, we cannot insert or remove OverlayEntry during the build phase.

TahaTesser

Great work! Just some initial thoughts.

TahaTesser · 2025-02-19T16:09:07Z

packages/flutter/lib/src/material/range_slider.dart

-
-  OverlayEntry? overlayEntry;
+  Widget _buildValueIndicator(ShowValueIndicator? showValueIndicator) {
+    late final Widget valueIndicator = CompositedTransformFollower(


Suggested change

late final Widget valueIndicator = CompositedTransformFollower(

late final Widget valueIndicator = CompositedTransformFollower(

Is late required since the value is assigned here.

If valueIndicator is never accessed, the assignment expression for valueIndicator will not be executed. It is not necessarily required to create it in the subsequent code.

the late isn't required to execute this code.

TahaTesser · 2025-02-19T16:09:36Z

packages/flutter/lib/src/material/range_slider.dart

+      link: _layerLink,
+      child: _ValueIndicatorRenderObjectWidget(state: this),
+    );
+    late final Widget valueIndicatorWhenDragged = ValueListenableBuilder<bool>(


similarly, late is used but value is also assigned here.

TahaTesser · 2025-02-19T16:15:21Z

packages/flutter/lib/src/material/range_slider.dart

+  void hideValueIndicator() {
+    assert(mounted);
+    _showValueIndicatorForDragged.value = false;


Just making sure. Once the portal controller is created and assigned to shown, are we disposing it when value indicator is hidden? Considering a screen might have a bunch sliders and each of one of them might create a portal controller without being disposed.

Do you mean OverlayPortalController? OverlayPortalController does not need to dispose.

The OverlayChild will always be displayed. When ShowValueIndicator is set to be shown during dragging, _showValueIndicatorForDragged controls whether _ValueIndicatorRenderObjectWidget is mounted to the tree within the OverlayChild.

TahaTesser · 2025-02-21T15:35:14Z

FYI @LongCatIsLooong on the overlay portal implementation. I was told you're working on something that would help Slider.

TahaTesser · 2025-02-25T14:45:04Z

FYI @LongCatIsLooong on the overlay portal implementation. I was told you're working on something that would help Slider.

Here is the PR #163575

LongCatIsLooong · 2025-02-25T19:02:34Z

packages/flutter/lib/src/material/range_slider.dart

+  late final OverlayPortalController _valueIndicatorOverlayPortalController =
+      OverlayPortalController()..show();
+  // Control whether the value indicator is visible only when it needs to be shown during dragging.
+  late final ValueNotifier<bool> _showValueIndicatorForDragged = ValueNotifier<bool>(false);


nit: I'm not familiar with the implementation, but adding the new state variable would probably make the implementation more complicated than checking if the animation status is .dismissed?

That's awesome! I completely overlooked that. It cleaned up a lot of code.

packages/flutter/lib/src/material/range_slider.dart

LongCatIsLooong

I think I looked into doing that before, the slider theming API could have been much cleaner if we could use inherited widgets, so thanks for converting the implementation to using OverlayPortal! The OverlayPortal change LGTM.

TahaTesser

LGTM with some nits

packages/flutter/lib/src/material/range_slider.dart

TahaTesser · 2025-03-05T14:24:58Z

packages/flutter/lib/src/material/slider_theme.dart

+  @Deprecated(
+    'Use ShowValueIndicator.onDrag. '
+    'This feature was deprecated after v3.28.0-1.0.pre.',
+  )


Do you plan to write a dart fix for this deprecation? It'd be best to deprecate this property in a separate PR with dart fix.

I will write this in a separate PR.

The dart fix should be included in this PR, not a separate change.

If the property is deprecated in this PR then dart fix should be included.

Perhaps, I wasn't clear. I suggested to mark it as deprecated and include dart fix in a separate PR so the dart fix can be included with the deprecation.

dart fix is included in this PR.

packages/flutter/test/material/range_slider_test.dart

TahaTesser · 2025-03-05T14:37:56Z

@yiiim Could you please also update #162223 (comment) with new API changes. isDragged is now onDrag for instance.

yiiim · 2025-03-06T07:34:38Z

@Piinks Can you help find out the reason why the Google test failed?

TahaTesser

I just realised I approved it without making sure deprecation mark was reverted after @Piinks comment.

Please include dart fix in this PR if you plan to keep deprecation mark.

Piinks

@yiiim it looks like the Google testing shows the on tap functionality is broken by this change. When the slider is tapped on, it shows the value indicator in response. Can you take a look?

Piinks · 2025-03-17T15:01:29Z

packages/flutter/lib/fix_data/fix_material/fix_slider_theme.yaml

+          constant: 'onDrag'
+          inEnum: 'ShowValueIndicator'
+
+# Before adding a new fix: read instructions at the top of this file.


Nit: missing a newline here.

Piinks · 2025-03-17T15:02:30Z

packages/flutter/lib/fix_data/fix_material/fix_slider_theme.yaml

@@ -0,0 +1,35 @@
+# Copyright 2014 The Flutter Authors. All rights reserved.


I am not sure we need a new file just for one fix, can we just add this to the fixes in fix_material.yaml?

Dart fixes also need to be tested. Can you please add tests under the test_fixes directory? They demonstrate the code before and after the tool applies the migration.

yiiim · 2025-03-24T04:24:14Z

@yiiim it looks like the Google testing shows the on tap functionality is broken by this change. When the slider is tapped on, it shows the value indicator in response. Can you take a look?

Could you provide more information? I am unable to reproduce this.

Piinks · 2025-04-08T00:01:30Z

Could you provide more information? I am unable to reproduce this.

Thanks for your patience!

Here is a recreation of the code from the broken test.

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
      ),
      home: RangeSlidersDemo(),
    );
  }
}

class RangeSlidersDemo extends StatefulWidget {
  static const slug = 'range-slider';

  @override
  State<StatefulWidget> createState() => _RangeSlidersDemoState();
}

class _RangeSlidersDemoState extends State<RangeSlidersDemo> {
  RangeValues _continuousValues = const RangeValues(42, 49);
  RangeValues _discreteValues = const RangeValues(20, 40);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: [
            Column(
              children: [
                RangeSlider(
                  labels: RangeLabels(
                    _continuousValues.start.round().toString(),
                    _continuousValues.end.round().toString(),
                  ),
                  values: _continuousValues,
                  min: 0,
                  max: 100,
                  onChanged: (RangeValues values) {
                    setState(() {
                      _continuousValues = values;
                    });
                  },
                ),
                Text('Continuous Enabled'),
              ],
            ),
            SliderTheme(
              data: SliderTheme.of(context).copyWith(
                showValueIndicator: ShowValueIndicator.onlyForContinuous,
              ),
              child: Column(
                children: [
                  RangeSlider(
                    // Key is for scuba testing only.
                    key: Key('continuousRangeSlider'),
                    labels: RangeLabels(
                      _continuousValues.start.round().toString(),
                      _continuousValues.end.round().toString(),
                    ),
                    values: _continuousValues,
                    min: 0,
                    max: 100,
                    onChanged: (RangeValues values) {
                      setState(() {
                        _continuousValues = values;
                      });
                    },
                  ),
                  Text('Continuous Enabled Value Indicator'),
                ],
              ),
            ),
            SliderTheme(
              data: SliderTheme.of(context).copyWith(
                showValueIndicator: ShowValueIndicator.onlyForDiscrete,
              ),
              child: Column(
                children: [
                  RangeSlider(
                    key: Key('discreteSlider'),
                    labels: RangeLabels(
                      _discreteValues.start.round().toString(),
                      _discreteValues.end.round().toString(),
                    ),
                    min: 0,
                    max: 100,
                    values: _discreteValues,
                    divisions: 5,
                    onChanged: (RangeValues values) {
                      setState(() {
                        _discreteValues = values;
                      });
                    },
                  ),
                  Text('Discrete Enabled Value Indicator'),
                ],
              ),
            ),
            Column(
              children: [
                RangeSlider(
                  values: _continuousValues,
                  min: 0,
                  max: 100,
                  onChanged: null,
                ),
                Text('Continuous Disabled'),
              ],
            ),
            Column(
              children: [
                RangeSlider(
                  divisions: 5,
                  min: 0,
                  max: 100,
                  values: _discreteValues,
                  onChanged: null,
                ),
                Text('Discrete Disabled'),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

This issue is on the middle one with two values showing. This image does not reflect my cursor tapping on it, which briefly reveals the indicators on both sides.
The test is a screenshot test, where it taps and then takes the screenshot.

Piinks · 2025-05-19T19:15:44Z

Rebasing to get a fresh run from Google testing.

Piinks · 2025-06-02T23:44:24Z

Thanks again for your patience with this @yiiim. I have been working at this for a while trying to figure out what this change breaks.
I now have a runnable test for you that demonstrates the indicators are not showing as they were without this change:

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
      ),
      home: RangeSlidersDemo(),
    );
  }
}

class RangeSlidersDemo extends StatefulWidget {
  static const slug = 'range-slider';

  @override
  State<StatefulWidget> createState() => _RangeSlidersDemoState();
}

class _RangeSlidersDemoState extends State<RangeSlidersDemo> {
  RangeValues _continuousValues = const RangeValues(42, 49);
  RangeValues _discreteValues = const RangeValues(20, 40);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: [
            Column(
              children: [
                RangeSlider(
                  labels: RangeLabels(
                    _continuousValues.start.round().toString(),
                    _continuousValues.end.round().toString(),
                  ),
                  values: _continuousValues,
                  min: 0,
                  max: 100,
                  onChanged: (RangeValues values) {
                    setState(() {
                      _continuousValues = values;
                    });
                  },
                ),
                Text('Continuous Enabled'),
              ],
            ),
            SliderTheme(
              data: SliderTheme.of(context).copyWith(
                showValueIndicator: ShowValueIndicator.onlyForContinuous,
              ),
              child: Column(
                children: [
                  RangeSlider(
                    // Key is for scuba testing only.
                    key: Key('continuousRangeSlider'),
                    labels: RangeLabels(
                      _continuousValues.start.round().toString(),
                      _continuousValues.end.round().toString(),
                    ),
                    values: _continuousValues,
                    min: 0,
                    max: 100,
                    onChanged: (RangeValues values) {
                      setState(() {
                        _continuousValues = values;
                      });
                    },
                  ),
                  Text('Continuous Enabled Value Indicator'),
                ],
              ),
            ),
            SliderTheme(
              data: SliderTheme.of(context).copyWith(
                showValueIndicator: ShowValueIndicator.onlyForDiscrete,
              ),
              child: Column(
                children: [
                  RangeSlider(
                    key: Key('discreteSlider'),
                    labels: RangeLabels(
                      _discreteValues.start.round().toString(),
                      _discreteValues.end.round().toString(),
                    ),
                    min: 0,
                    max: 100,
                    values: _discreteValues,
                    divisions: 5,
                    onChanged: (RangeValues values) {
                      setState(() {
                        _discreteValues = values;
                      });
                    },
                  ),
                  Text('Discrete Enabled Value Indicator'),
                ],
              ),
            ),
            Column(
              children: [
                RangeSlider(
                  values: _continuousValues,
                  min: 0,
                  max: 100,
                  onChanged: null,
                ),
                Text('Continuous Disabled'),
              ],
            ),
            Column(
              children: [
                RangeSlider(
                  divisions: 5,
                  min: 0,
                  max: 100,
                  values: _discreteValues,
                  onChanged: null,
                ),
                Text('Discrete Disabled'),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

void main() {
  testWidgets('Repro', (WidgetTester tester) async {
    final binding = TestWidgetsFlutterBinding.ensureInitialized();
    Size oldSize = binding.window.physicalSize;
    binding.window.physicalSizeTestValue = Size(1400, 1200);
    await tester.pumpWidget(MyApp());

      await tester.tap(find.byKey(Key('discreteSlider')));
      await tester.pumpAndSettle();

      await expectLater(find.byType(MaterialApp), matchesGoldenFile('goldenFile.png'));
      binding.window.physicalSizeTestValue = oldSize;
  });

yiiim · 2025-06-06T04:05:58Z

The Google testing issue has been resolved because the problem only occurred within the same frame during press and release gestures. Therefore, it was not discovered during the run. Many thanks to @Piinks for taking the time to investigate this matter.

packages/flutter/test_fixes/material/material.dart

Piinks · 2025-06-06T15:05:55Z

The Google testing issue has been resolved because the problem only occurred within the same frame during press and release gestures. Therefore, it was not discovered during the run. Many thanks to @Piinks for taking the time to investigate this matter.

Thanks very much for your patience while we figured it out! Can you add the test I provided so we have it captured for the future now? :)

… sider_value_indicator

Outdated

Piinks

LGTM 🎊

…er/flutter#162223)

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/flutter@824868f...f79452e 2025-06-12 [email protected] Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514) 2025-06-12 [email protected] Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395) 2025-06-12 [email protected] Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498) 2025-06-12 [email protected] Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495) 2025-06-11 [email protected] Allow the Slider to always show the value indicator. (flutter/flutter#162223) 2025-06-11 [email protected] Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492) 2025-06-11 [email protected] Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602) 2025-06-11 [email protected] Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062) 2025-06-11 [email protected] Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473) 2025-06-11 [email protected] [impellerc] add GLES shader define. (flutter/flutter#170375) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477) 2025-06-11 [email protected] Pause UIScene migration (flutter/flutter#170457) 2025-06-11 [email protected] iOS tool dylibs do not need entitlements (flutter/flutter#170448) 2025-06-11 [email protected] Adds getters for different formats of build mode name (flutter/flutter#170251) 2025-06-11 [email protected] Remove all code in `conductor/core` that is now unused (flutter/flutter#170454) 2025-06-11 [email protected] Roll Packages from 974f152 to 0b322a2 (9 revisions) (flutter/flutter#170462) 2025-06-11 [email protected] Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453) 2025-06-11 [email protected] Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029) 2025-06-11 [email protected] Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645) 2025-06-11 [email protected] Add CupertinoRadio widget of the week video (flutter/flutter#170027) 2025-06-11 [email protected] Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828) 2025-06-11 [email protected] [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262) 2025-06-11 [email protected] [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022) 2025-06-11 [email protected] Tiny clean-up in triage docs (flutter/flutter#170429) 2025-06-11 [email protected] Roll pub packages (flutter/flutter#170444) 2025-06-11 [email protected] [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398) 2025-06-11 [email protected] Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163) 2025-06-11 [email protected] Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139) 2025-06-11 [email protected] Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430) 2025-06-11 [email protected] Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412) 2025-06-11 [email protected] Use pathops module groups (flutter/flutter#169857) 2025-06-10 [email protected] Roll pub packages (flutter/flutter#170399) 2025-06-10 [email protected] Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187) 2025-06-10 [email protected] Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381) 2025-06-10 [email protected] [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389) 2025-06-10 [email protected] Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309) 2025-06-10 [email protected] fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816) 2025-06-10 [email protected] fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807) 2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377) 2025-06-10 [email protected] [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738) 2025-06-10 [email protected] Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363) 2025-06-10 [email protected] Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364) 2025-06-10 [email protected] [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313) ...

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/flutter@824868f...f79452e 2025-06-12 [email protected] Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514) 2025-06-12 [email protected] Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395) 2025-06-12 [email protected] Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498) 2025-06-12 [email protected] Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495) 2025-06-11 [email protected] Allow the Slider to always show the value indicator. (flutter/flutter#162223) 2025-06-11 [email protected] Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492) 2025-06-11 [email protected] Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602) 2025-06-11 [email protected] Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062) 2025-06-11 [email protected] Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473) 2025-06-11 [email protected] [impellerc] add GLES shader define. (flutter/flutter#170375) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477) 2025-06-11 [email protected] Pause UIScene migration (flutter/flutter#170457) 2025-06-11 [email protected] iOS tool dylibs do not need entitlements (flutter/flutter#170448) 2025-06-11 [email protected] Adds getters for different formats of build mode name (flutter/flutter#170251) 2025-06-11 [email protected] Remove all code in `conductor/core` that is now unused (flutter/flutter#170454) 2025-06-11 [email protected] Roll Packages from 974f1522ee03 to 17c02a5 (9 revisions) (flutter/flutter#170462) 2025-06-11 [email protected] Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453) 2025-06-11 [email protected] Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029) 2025-06-11 [email protected] Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645) 2025-06-11 [email protected] Add CupertinoRadio widget of the week video (flutter/flutter#170027) 2025-06-11 [email protected] Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828) 2025-06-11 [email protected] [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262) 2025-06-11 [email protected] [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022) 2025-06-11 [email protected] Tiny clean-up in triage docs (flutter/flutter#170429) 2025-06-11 [email protected] Roll pub packages (flutter/flutter#170444) 2025-06-11 [email protected] [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398) 2025-06-11 [email protected] Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163) 2025-06-11 [email protected] Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139) 2025-06-11 [email protected] Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430) 2025-06-11 [email protected] Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412) 2025-06-11 [email protected] Use pathops module groups (flutter/flutter#169857) 2025-06-10 [email protected] Roll pub packages (flutter/flutter#170399) 2025-06-10 [email protected] Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187) 2025-06-10 [email protected] Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381) 2025-06-10 [email protected] [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389) 2025-06-10 [email protected] Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309) 2025-06-10 [email protected] fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816) 2025-06-10 [email protected] fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807) 2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377) 2025-06-10 [email protected] [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738) 2025-06-10 [email protected] Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363) 2025-06-10 [email protected] Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364) 2025-06-10 [email protected] [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 26, 2025

yiiim added the c: new feature Nothing broken; request for a new capability label Jan 27, 2025

Piinks self-requested a review January 29, 2025 19:10

Piinks reviewed Feb 14, 2025

View reviewed changes

TahaTesser self-requested a review February 17, 2025 09:23

TahaTesser reviewed Feb 17, 2025

View reviewed changes

packages/flutter/lib/src/material/range_slider.dart Outdated Show resolved Hide resolved

yiiim force-pushed the sider_value_indicator branch from bb3d73d to da97b9b Compare February 17, 2025 15:14

TahaTesser self-requested a review February 19, 2025 16:05

TahaTesser reviewed Feb 19, 2025

View reviewed changes

TahaTesser requested a review from LongCatIsLooong February 25, 2025 14:46

LongCatIsLooong reviewed Feb 25, 2025

View reviewed changes

packages/flutter/lib/src/material/range_slider.dart Outdated Show resolved Hide resolved

LongCatIsLooong reviewed Feb 25, 2025

View reviewed changes

packages/flutter/lib/src/material/range_slider.dart Outdated Show resolved Hide resolved

LongCatIsLooong reviewed Feb 25, 2025

View reviewed changes

TahaTesser self-requested a review March 4, 2025 15:29

TahaTesser approved these changes Mar 5, 2025

View reviewed changes

yiiim requested a review from Piinks March 6, 2025 07:34

TahaTesser self-requested a review March 11, 2025 18:03

TahaTesser previously requested changes Mar 11, 2025

View reviewed changes

Piinks reviewed Mar 17, 2025

View reviewed changes

github-actions bot added the c: tech-debt Technical debt, code quality, testing, etc. label Mar 18, 2025

yiiim force-pushed the sider_value_indicator branch from b6b9699 to 0fd3f15 Compare March 19, 2025 01:57

Piinks force-pushed the sider_value_indicator branch 2 times, most recently from e5761b5 to 10a4509 Compare May 21, 2025 19:14

Piinks force-pushed the sider_value_indicator branch from 10a4509 to b84134e Compare May 29, 2025 18:13

yiiim force-pushed the sider_value_indicator branch from b84134e to 2cec0fe Compare June 5, 2025 07:39

yiiim added 2 commits June 6, 2025 09:38

sider_value_indicator

d03f8a3

fix google testing

55662b8

yiiim force-pushed the sider_value_indicator branch from 920d195 to 55662b8 Compare June 6, 2025 01:38

Piinks reviewed Jun 6, 2025

View reviewed changes

packages/flutter/test_fixes/material/material.dart Outdated Show resolved Hide resolved

yiiim added 2 commits June 9, 2025 12:32

sider_value_indicator

784987b

fix google testing

23a4e81

yiiim force-pushed the sider_value_indicator branch from 55662b8 to 23a4e81 Compare June 9, 2025 04:32

yiiim added 2 commits June 9, 2025 12:33

Merge branch 'sider_value_indicator' of github.com:yiiim/flutter into…

d015fac

… sider_value_indicator

++

94c1fce

Piinks approved these changes Jun 11, 2025

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2025

auto-submit bot added this pull request to the merge queue Jun 11, 2025

Merged via the queue into flutter:master with commit 972c181 Jun 12, 2025
75 of 76 checks passed

github-project-automation bot moved this from In Progress to Done in Google Testing Queue Jun 12, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

engine-flutter-autoroll mentioned this pull request Jun 12, 2025

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/packages#9419

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2025

972c18121 Allow the Slider to always show the value indicator. (flutt…

057184e

…er/flutter#162223)

Piinks mentioned this pull request Jun 13, 2025

Flutter Notable Commits - 2025 #161460

Open

	late final Widget valueIndicator = CompositedTransformFollower(
	late final Widget valueIndicator = CompositedTransformFollower(

		@@ -0,0 +1,35 @@
		# Copyright 2014 The Flutter Authors. All rights reserved.

Allow the Slider to always show the value indicator. #162223

Allow the Slider to always show the value indicator. #162223

Conversation

yiiim commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yiiim commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TahaTesser commented Feb 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TahaTesser commented Mar 5, 2025

Uh oh!

yiiim commented Mar 6, 2025

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

yiiim commented Jan 26, 2025 •

edited

Loading

TahaTesser left a comment •

edited

Loading

yiiim commented Feb 17, 2025 •

edited

Loading

TahaTesser commented Feb 21, 2025 •

edited

Loading