Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` #167602

LouiseHsu · 2025-04-22T22:19:29Z

Partially addresses #154138
Closes #170386

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

matanlurey · 2025-04-23T02:02:31Z

Might not be helpful: but you actually don't need to create a PR to run a LED run, it can just be on any internet accessible Git repo (like your own GitHub or Git on Borg etc).

matanlurey · 2025-04-23T02:06:47Z

Also would love your feedback on #167613

gaaclarke

This is looking good, I just have a few questions and nits.

gaaclarke · 2025-06-10T22:42:36Z

dev/devicelab/lib/tasks/perf_tests.dart

+      // Get ID from Info.plist
+      final ProcessResult plistIDResult = await Process.run(
+        workingDirectory: testDirectory,
+        'plutil',


Do we have existing precedent where we assume "plutil" is on the $PATH? Reading it as an XML file in dart seems more robust. That would only break if we have binary plists, I don't think Info.plist is ever binary.

Hmm, I saw some examples of plutil being used before I used it so I thought it was okay - like

flutter/packages/flutter_tools/bin/xcode_backend.dart

Line 419 in db8a64f

ProcessResult result = runSync('plutil', <String>[

gaaclarke · 2025-06-10T22:44:36Z

dev/devicelab/lib/tasks/perf_tests.dart

+    return inDirectory<List<double>>(testDirectory, () async {
+      List<dynamic> resultsJson = <dynamic>[];
+      const String resultsBundleName = 'benchmarkResults.xcresult';
+      // Get ID from Info.plist


These commits should be full sentences.

https://google.github.io/styleguide/cppguide.html#Punctuation_Spelling_and_Grammar

gaaclarke · 2025-06-10T22:47:02Z

dev/devicelab/lib/tasks/perf_tests.dart

+
+        testRefID =
+        // ignore: avoid_dynamic_calls
+            actionsInvocationRecordJSON['actions']['_values'][0]['actionResult']['testsRef']['id']['_value']


This seems fragile, like the next version of xcode could break it. Do you think there may be a more robust way to hunt this down? I don't have anything in mind, just wondering.

Is there a version in the json somewhere?

i dont think so, i did a search for "16." and didnt see anything.

Heres a copy of that JSON, its the first value 0~fdOExp-kqULoQEJCNGCibXGdPVKPO3aiB8IcprdkA6Ew5vCaoMM2Kbvs3_z50Fz76b8XCfoNhgdlsty_G6d9RQ==
actioninvocationrecord.txt

gaaclarke · 2025-06-10T22:52:50Z

dev/devicelab/lib/tasks/perf_tests.dart

+        'PROVISIONING_PROFILE_SPECIFIER=$provisioningProfile',
+      ]);
+
+      final List<double> extractedLaunchTimes = await getMetricsFromXCResults();


nit: The xcresults should be passed in as an argument to getMetricsFromXCResults.

gaaclarke · 2025-06-10T23:40:45Z

fyi the "linux analyze failure" is apropos

gaaclarke

LGTM I think hunting down things in the JSON file seems fragile, but I don't have a good solution to avoid this being broken in the future.

…wiftui` (flutter/flutter#167602)

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/flutter@824868f...f79452e 2025-06-12 [email protected] Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514) 2025-06-12 [email protected] Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395) 2025-06-12 [email protected] Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498) 2025-06-12 [email protected] Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495) 2025-06-11 [email protected] Allow the Slider to always show the value indicator. (flutter/flutter#162223) 2025-06-11 [email protected] Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492) 2025-06-11 [email protected] Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602) 2025-06-11 [email protected] Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062) 2025-06-11 [email protected] Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473) 2025-06-11 [email protected] [impellerc] add GLES shader define. (flutter/flutter#170375) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477) 2025-06-11 [email protected] Pause UIScene migration (flutter/flutter#170457) 2025-06-11 [email protected] iOS tool dylibs do not need entitlements (flutter/flutter#170448) 2025-06-11 [email protected] Adds getters for different formats of build mode name (flutter/flutter#170251) 2025-06-11 [email protected] Remove all code in `conductor/core` that is now unused (flutter/flutter#170454) 2025-06-11 [email protected] Roll Packages from 974f152 to 0b322a2 (9 revisions) (flutter/flutter#170462) 2025-06-11 [email protected] Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453) 2025-06-11 [email protected] Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029) 2025-06-11 [email protected] Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645) 2025-06-11 [email protected] Add CupertinoRadio widget of the week video (flutter/flutter#170027) 2025-06-11 [email protected] Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828) 2025-06-11 [email protected] [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262) 2025-06-11 [email protected] [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022) 2025-06-11 [email protected] Tiny clean-up in triage docs (flutter/flutter#170429) 2025-06-11 [email protected] Roll pub packages (flutter/flutter#170444) 2025-06-11 [email protected] [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398) 2025-06-11 [email protected] Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163) 2025-06-11 [email protected] Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139) 2025-06-11 [email protected] Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430) 2025-06-11 [email protected] Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412) 2025-06-11 [email protected] Use pathops module groups (flutter/flutter#169857) 2025-06-10 [email protected] Roll pub packages (flutter/flutter#170399) 2025-06-10 [email protected] Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187) 2025-06-10 [email protected] Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381) 2025-06-10 [email protected] [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389) 2025-06-10 [email protected] Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309) 2025-06-10 [email protected] fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816) 2025-06-10 [email protected] fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807) 2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377) 2025-06-10 [email protected] [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738) 2025-06-10 [email protected] Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363) 2025-06-10 [email protected] Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364) 2025-06-10 [email protected] [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313) ...

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/flutter@824868f...f79452e 2025-06-12 [email protected] Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514) 2025-06-12 [email protected] Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395) 2025-06-12 [email protected] Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498) 2025-06-12 [email protected] Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495) 2025-06-11 [email protected] Allow the Slider to always show the value indicator. (flutter/flutter#162223) 2025-06-11 [email protected] Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492) 2025-06-11 [email protected] Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602) 2025-06-11 [email protected] Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062) 2025-06-11 [email protected] Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473) 2025-06-11 [email protected] [impellerc] add GLES shader define. (flutter/flutter#170375) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487) 2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477) 2025-06-11 [email protected] Pause UIScene migration (flutter/flutter#170457) 2025-06-11 [email protected] iOS tool dylibs do not need entitlements (flutter/flutter#170448) 2025-06-11 [email protected] Adds getters for different formats of build mode name (flutter/flutter#170251) 2025-06-11 [email protected] Remove all code in `conductor/core` that is now unused (flutter/flutter#170454) 2025-06-11 [email protected] Roll Packages from 974f1522ee03 to 17c02a5 (9 revisions) (flutter/flutter#170462) 2025-06-11 [email protected] Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453) 2025-06-11 [email protected] Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029) 2025-06-11 [email protected] Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645) 2025-06-11 [email protected] Add CupertinoRadio widget of the week video (flutter/flutter#170027) 2025-06-11 [email protected] Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828) 2025-06-11 [email protected] [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262) 2025-06-11 [email protected] [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022) 2025-06-11 [email protected] Tiny clean-up in triage docs (flutter/flutter#170429) 2025-06-11 [email protected] Roll pub packages (flutter/flutter#170444) 2025-06-11 [email protected] [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398) 2025-06-11 [email protected] Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163) 2025-06-11 [email protected] Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139) 2025-06-11 [email protected] Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430) 2025-06-11 [email protected] Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412) 2025-06-11 [email protected] Use pathops module groups (flutter/flutter#169857) 2025-06-10 [email protected] Roll pub packages (flutter/flutter#170399) 2025-06-10 [email protected] Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187) 2025-06-10 [email protected] Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381) 2025-06-10 [email protected] [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389) 2025-06-10 [email protected] Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309) 2025-06-10 [email protected] fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816) 2025-06-10 [email protected] fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631) 2025-06-10 [email protected] Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807) 2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377) 2025-06-10 [email protected] [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738) 2025-06-10 [email protected] Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363) 2025-06-10 [email protected] Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364) 2025-06-10 [email protected] [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313) ...

.

ea9b3c1

LouiseHsu changed the title ~~more led testing~~ more led testing dont look 🥴 Apr 22, 2025

LouiseHsu added 12 commits April 23, 2025 15:34

try?

10580ab

try generic device?

3cf2585

generic name?

aa02843

specify arm

6276350

verbose

89086f0

codesigning again

e2c560c

codesign?

80bef2a

sigh add print ls

af57be1

i hate codesigning sooooo much

2a1e6a0

,

fd1e545

WHERE IS MY RESULTS FILE?

adda969

check results arent empty

cc34932

LouiseHsu changed the title ~~more led testing dont look 🥴~~ Add time to first frame for Mac_arm64_ios imitation_game_flutter Apr 29, 2025

LouiseHsu changed the title ~~Add time to first frame for Mac_arm64_ios imitation_game_flutter~~ Add time to first frame for Mac_arm64_ios imitation_game_swiftui Apr 29, 2025

LouiseHsu added 10 commits May 6, 2025 17:12

.

b86028d

oh

e078796

legacy

fbdcd41

progress

e83d019

test

bae4583

conflict

0ac3e9f

oops

e2ace60

no warnings allowed!

cfe10c1

format

f189132

FORMATTTTTTT

35edb29

LouiseHsu requested a review from gaaclarke June 10, 2025 20:03

LouiseHsu marked this pull request as ready for review June 10, 2025 20:03

LouiseHsu requested a review from matanlurey as a code owner June 10, 2025 20:03

gaaclarke reviewed Jun 10, 2025

View reviewed changes

pr comments!

13b0ae0

gaaclarke approved these changes Jun 11, 2025

View reviewed changes

LouiseHsu added 3 commits June 11, 2025 11:11

LICENSEEEEE

a8f2b08

ANALYZEEEE

85377ae

:(

ff3fb05

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2025

auto-submit bot added this pull request to the merge queue Jun 11, 2025

Merged via the queue into flutter:master with commit 2697715 Jun 12, 2025
150 of 151 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

engine-flutter-autoroll mentioned this pull request Jun 12, 2025

Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) flutter/packages#9419

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2025

269771548 Add time to first frame for `Mac_arm64_ios imitation_game_s…

8494dd2

…wiftui` (flutter/flutter#167602)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` #167602

Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` #167602

LouiseHsu commented Apr 22, 2025 •

edited

Loading

Uh oh!

matanlurey commented Apr 23, 2025

Uh oh!

matanlurey commented Apr 23, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

gaaclarke Jun 10, 2025

Uh oh!

LouiseHsu Jun 11, 2025

Uh oh!

gaaclarke Jun 10, 2025

Uh oh!

LouiseHsu Jun 11, 2025

Uh oh!

gaaclarke Jun 10, 2025

Uh oh!

gaaclarke Jun 10, 2025

Uh oh!

LouiseHsu Jun 10, 2025

Uh oh!

gaaclarke Jun 10, 2025

Uh oh!

gaaclarke commented Jun 10, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

Uh oh!

Uh oh!

Add time to first frame for Mac_arm64_ios imitation_game_swiftui #167602

Add time to first frame for Mac_arm64_ios imitation_game_swiftui #167602

Conversation

LouiseHsu commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

matanlurey commented Apr 23, 2025

Uh oh!

matanlurey commented Apr 23, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Jun 10, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` #167602

Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` #167602

LouiseHsu commented Apr 22, 2025 •

edited

Loading