Skip to content

Remove feature label NodeOutOfServiceVolumeDetach #129680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Remove feature label NodeOutOfServiceVolumeDetach #129680

merged 1 commit into from
Jun 12, 2025
+1 −6

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 17, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

NodeOutOfServiceVolumeDetach feature-gate was GA in 1.28 and removed in 1.32. so the feature-label is unnecessary.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2025
@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

The affected tests should be tested by the following job:
/test pull-kubernetes-e2e-gce-storage-disruptive

@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 17, 2025
@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

/cc @sonasingh46 @xing-yang

@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

kubernetes/test-infra@a32a3f8 removed NodeOutOfServiceVolumeDetach from its focus list. So we need to drop this feature label from the test to enable it to run on other jobs, like pull-kubernetes-e2e-gce-storage-disruptive.

@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

unrelated failures
/test pull-kubernetes-e2e-gce-storage-disruptive

@carlory
Copy link
Member Author

carlory commented Jan 17, 2025

pull-kubernetes-e2e-gce-storage-disruptive is broken.

/test pull-kubernetes-e2e-gce-serial

@xing-yang
Copy link
Contributor

I'm not sure where we can run this test for NodeOutOfServiceVolumeDetach. There were concerns with regard to adding tests that depends on a specific cloud provider. For that reason, we didn't merge a scale test for NodeOutOfServiceVolumeDetach, instead we added an integration test: #118848, #128404.

cc @jsafrane @gnufied @msau42

@carlory carlory mentioned this pull request Jan 21, 2025
Merged
@carlory
Copy link
Member Author

carlory commented Jan 21, 2025

I'm not sure where we can run this test for NodeOutOfServiceVolumeDetach.

@xing-yang pull-kubernetes-e2e-gce-storage-disruptive can run this test but it is broken by kubernetes/test-infra#31981. I create a PR to fix it. Can you help to review kubernetes/test-infra#34186?

@carlory
Copy link
Member Author

carlory commented Jan 22, 2025

/test pull-kubernetes-e2e-gce-storage-disruptive

@carlory
Copy link
Member Author

carlory commented Jan 22, 2025

image
@xing-yang The pull-kubernetes-e2e-gce-storage-disruptive job is successful

@jsafrane
Copy link
Member

jsafrane commented Mar 7, 2025

/retest

1 similar comment
@SataQiu
Copy link
Member

SataQiu commented Mar 8, 2025

/retest

@carlory
Copy link
Member Author

carlory commented Mar 10, 2025

@jsafrane @SataQiu the job pull-kubernetes-e2e-gce-serial can not be successful because all provider is the NULL provider. And it is not required and manually triggered by me. Let's skip the job.

/skip pull-kubernetes-e2e-gce-serial

image

@carlory carlory force-pushed the rm-feature-label-NodeOutOfServiceVolumeDetach branch from 6b5f5bc to d678b42 Compare April 11, 2025 03:50
@carlory
Copy link
Member Author

carlory commented Apr 11, 2025

/skip pull-kubernetes-e2e-gce-serial

@carlory
Copy link
Member Author

carlory commented Apr 24, 2025

/retest

@carlory
Copy link
Member Author

carlory commented Apr 24, 2025

/test pull-kubernetes-unit

@carlory carlory force-pushed the rm-feature-label-NodeOutOfServiceVolumeDetach branch from d678b42 to 7c53a5a Compare April 24, 2025 06:54
@carlory
Copy link
Member Author

carlory commented Apr 24, 2025

/test pull-kubernetes-e2e-gce-storage-snapshot

@carlory
Copy link
Member Author

carlory commented Jun 12, 2025

kindly ping @xing-yang @jsafrane

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 180b3dbd5cc1c9024fcb3038b505ca3b7cd4f961

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 12, 2025 •
edited
Loading

@carlory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-serial 6b5f5bc link false /test pull-kubernetes-e2e-gce-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@carlory
Copy link
Member Author

carlory commented Jun 12, 2025

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 9ad4659 into kubernetes:master Jun 12, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 12, 2025
@carlory carlory deleted the rm-feature-label-NodeOutOfServiceVolumeDetach branch June 12, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@SataQiu SataQiu Awaiting requested review from SataQiu

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8s-ci-robot @xing-yang @jsafrane @SataQiu