Skip to content

Add 'Reduce Into Instead Of Loop' rule #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Add 'Reduce Into Instead Of Loop' rule #6078

wants to merge 32 commits into from

Conversation

snofla
Copy link

@snofla snofla commented May 12, 2025

Adds an idiomatic rule that suggests using reduce(into:) when a for ... in loop is encountered that references a collection variable (of type Array, Set or Dictionary).

This is mostly to encourage immutability, higher-order functions and to prevent dangling vardecls.

The canonical triggering example is:

            var result: [SomeType] = []
            for eachN in someSequence {
                ↓result[someIndex] = eachN
            }

The rule does not check for mutating methods on sequences within a for ... in statement.

@SwiftLintBot
Copy link

SwiftLintBot commented May 12, 2025

399 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:433:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:479:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:432:21: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:427:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:74:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:131:14: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/URLEncodedFormEncoder.swift:1082:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:442:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:467:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:494:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:547:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:564:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:582:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:604:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:626:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:651:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/ConcurrencyTests.swift:838:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:604:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/App/l10n/tools/download-translations-from-transifex.swift:241:5: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/CertificateUtilitiesTests/CertificatePinningTest.swift:21:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/CertificateUtilitiesTests/CertificatePinningTest.swift:34:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/CertificateUtilitiesTests/CertificatePinningTest.swift:62:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/CertificateUtilitiesTests/CertificatePinningTest.swift:75:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveNewsTests/CardGeneratorTests.swift:17:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/ClientTests/User Scripts/ScriptExecutionTests.swift:373:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveWalletTests/TransactionsActivityStoreTests.swift:154:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveWalletTests/UserAssetsStoreTests.swift:49:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveWalletTests/AccountActivityStoreTests.swift:94:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/SharedTests/BytesTests.swift:18:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Customize/SourceSuggestionsView.swift:20:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Customize/SearchResultsView.swift:201:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource.swift:582:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource.swift:762:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource.swift:1048:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/SpeechRecognition/SpeechRecognizer.swift:253:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Settings/CustomNetworkDetailsView.swift:254:11: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/ManageSiteConnectionsStore.swift:53:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:743:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NetworkStore.swift:223:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/PortfolioStore.swift:504:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/PortfolioStore.swift:518:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SelectAccountTokenStore.swift:258:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SelectAccountTokenStore.swift:307:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/AccountsStore.swift:193:15: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NFTStore.swift:326:19: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NFTStore.swift:354:21: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NFTStore.swift:537:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NFTStore.swift:577:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NFTStore.swift:605:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/TransactionConfirmationStore.swift:960:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Onboarding/RestoreWalletView.swift:77:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:202:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:256:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:289:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:662:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:675:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/SolanaTxManagerProxyExtensions.swift:29:11: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/WalletServiceExtensions.swift:61:11: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/RpcServiceExtensions.swift:380:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Blockies/Blockies.swift:47:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Blockies/Blockies.swift:81:11: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/URLPartinessScriptHandler.swift:70:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Sandboxed/SiteStateListenerScriptHandler.swift:98:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Widgets.swift:67:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+KeyCommands.swift:390:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ContentBlocker/ContentBlockerHelper.swift:102:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Extensions/AsyncAwait.swift:43:9: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/TextRecognition/AIChatPDFRecognition.swift:54:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Markdown/Code Highlight/MarkdownParser.swift:99:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/PlaylistUI/CarPlayController.swift:231:7: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Sources/DataBrokerProtection-macOS/DataCaching/DataBrokerProtectionDataManager.swift:433:21: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Sources/DataBrokerProtection-macOS/UIWeb/UIMapper.swift:145:21: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Sources/DataBrokerProtection-macOS/Debug/DataBaseBrowser/DataBrokerDatabaseBrowserViewModel.swift:110:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Sources/DataBrokerProtection-macOS/Debug/DataBrokerRunCustomJSONViewModel.swift:456:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift:151:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Autofill/Debug/AutofillCredentialsDebugViewModel.swift:127:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/View/TabBarViewItem.swift:1234:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/View/TabBarViewItem.swift:1243:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Tab/UserScripts/UserScripts.swift:213:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/BookmarksBar/View/BookmarksBarViewModel.swift:152:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift:903:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/DataImport/ThirdPartyBrowser.swift:250:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/DataImport/Model/DataImportViewModel.swift:358:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Database/CoreDataStore.swift:238:21: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/DateExtension.swift:83:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/DateExtension.swift:99:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/View/AppKit/LoadingProgressView.swift:78:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/View/AppKit/LoadingProgressView.swift:79:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Fire/Model/Fire.swift:635:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Legacy/LegacyBookmarksStoreMigration.swift:104:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Model/BookmarkSidebarTreeController.swift:83:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/PrivacyDashboard/View/PrivacyDashboardViewController.swift:364:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Services/LocalBookmarkStore.swift:979:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Menus/HistoryMenu.swift:247:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Menus/MainMenu.swift:562:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/VPNLocation/VPNLocationViewModel.swift:136:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/scripts/appcast_manager/appcastManager.swift:54:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/UIWeb/DBPUIWebConfiguration.swift:94:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/UIWeb/DBPUICommunicationModel.swift:323:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionCustomStatsProvider.swift:95:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/SecureVaultStorage/DataBrokerProtectionDatabase.swift:497:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/SecureVaultStorage/DataBrokerProtectionSecureVault.swift:256:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/CCF/DataBrokerProtectionUtils.swift:95:17: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/SecureVault/CreditCardValidation.swift:160:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ContentBlocking/ClickToLoadRulesSplitter.swift:116:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ContentBlocking/ClickToLoadRulesSplitter.swift:117:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/v2/Extensions/URL+QueryParamExtraction.swift:32:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Subscription/Managers/StorePurchaseManager/StorePurchaseManagerV2.swift:235:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Subscription/Managers/StorePurchaseManager/StorePurchaseManagerV2.swift:246:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Subscription/Managers/StorePurchaseManager/StorePurchaseManager.swift:190:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Subscription/Managers/StorePurchaseManager/StorePurchaseManager.swift:205:13: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Common/Extensions/ArrayExtension.swift:27:14: Warning: Prefer using reduce(into:) instead of mutating a sequence in a for _ in ... loop (reduce_into_instead_of_loop)
⚠️ Danger found 399 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 113.
18 Messages
📖 Building this branch resulted in a binary size of 25129.6 KiB vs 25052.41 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 1.06 s vs 1.02 s on main (3% slower).
📖 Linting Alamofire with this PR took 1.37 s vs 1.37 s on main (0% slower).
📖 Linting Brave with this PR took 9.46 s vs 9.45 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 23.54 s vs 23.54 s on main (0% slower).
📖 Linting Firefox with this PR took 11.24 s vs 11.27 s on main (0% faster).
📖 Linting Kickstarter with this PR took 10.69 s vs 10.58 s on main (1% slower).
📖 Linting Moya with this PR took 0.55 s vs 0.55 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 3.12 s vs 3.12 s on main (0% slower).
📖 Linting Nimble with this PR took 0.83 s vs 0.82 s on main (1% slower).
📖 Linting PocketCasts with this PR took 8.95 s vs 8.96 s on main (0% faster).
📖 Linting Quick with this PR took 0.47 s vs 0.47 s on main (0% slower).
📖 Linting Realm with this PR took 4.76 s vs 4.75 s on main (0% slower).
📖 Linting Sourcery with this PR took 2.43 s vs 2.43 s on main (0% slower).
📖 Linting Swift with this PR took 5.57 s vs 5.55 s on main (0% slower).
📖 Linting VLC with this PR took 1.45 s vs 1.44 s on main (0% slower).
📖 Linting Wire with this PR took 21.15 s vs 21.09 s on main (0% slower).
📖 Linting WordPress with this PR took 12.51 s vs 12.49 s on main (0% slower).

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants