Auto applied fixes

realm · snofla · Jun 18, 2023 · Jun 18, 2023 · Jun 19, 2023 · Jun 19, 2023
commit 1443cb7dc9fe87228c2a24faf66c950e9352e1d9
diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRule.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRule.swift
@@ -3,7 +3,7 @@ import SwiftSyntax
 typealias ReferencedVariable = ReduceIntoInsteadOfLoopRule.ReferencedVariable
 typealias CollectionType = ReduceIntoInsteadOfLoopRule.CollectionType
 
-@SwiftSyntaxRule
+@SwiftSyntaxRule(optIn: true)
 struct ReduceIntoInsteadOfLoopRule: Rule {
     var configuration = SeverityConfiguration<Self>(.warning)
 
@@ -28,7 +28,7 @@ internal extension ReduceIntoInsteadOfLoopRule {
             let selected = all.reduce(into: [ForStmtSyntax: [VariableDeclSyntax]]()) { partialResult, element in
                 // we're interested fully type declared and implicitly declared by initializer
                 let interestingVariableDecls = element.value.filter { variableDecl in
-                    return variableDecl.isTypeAnnotatedAndInitializer
+                    variableDecl.isTypeAnnotatedAndInitializer
                         || variableDecl.isCollectionTypeInitializer
                 }
                 guard !interestingVariableDecls.isEmpty else {
@@ -142,7 +142,7 @@ private extension VariableDeclSyntax {
             return false
         }
         guard let initializerClausePatternBinding = self.bindings.first(where: { patternBindingSyntax in
-            return patternBindingSyntax.initializer != nil
+            patternBindingSyntax.initializer != nil
         }) else {
             return false
         }
@@ -326,7 +326,7 @@ private extension FunctionCallExprSyntax {
 
 private extension SequenceExprSyntax {
     /// Detect assignment expression:
-    ///     varName[xxx] = ...  // index
+    ///     varName[xxx] = ... // index
     ///     varName = ...
     func referencedVariable(for varName: String) -> ReferencedVariable? {
         let exprList = self.elements
@@ -350,15 +350,15 @@ private extension SequenceExprSyntax {
                 position: exprList.positionAfterSkippingLeadingTrivia,
                 kind: .assignment(subscript: true)
             )
-        } else if let declExpr = firstExpr.as(DeclReferenceExprSyntax.self),
+        }
+        if let declExpr = firstExpr.as(DeclReferenceExprSyntax.self),
                   declExpr.baseName.tokenKind == .identifier(varName) {
             return ReferencedVariable(
                 name: varName,
                 position: exprList.positionAfterSkippingLeadingTrivia,
                 kind: .assignment(subscript: false)
             )
-        } else {
-            return nil
         }
+        return nil
     }
 }
diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRuleExamples.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRuleExamples.swift
@@ -24,7 +24,6 @@ struct ReduceIntoInsteadOfLoopRuleExamples {
 }
 
 extension ReduceIntoInsteadOfLoopRuleExamples {
-
     private static let triggeringDictionaryExamples: [Example] = [
         Example("""
             var result: Dictionary<SomeType1, SomeType2> = [:]
@@ -118,4 +117,3 @@ extension ReduceIntoInsteadOfLoopRuleExamples {
         """),
     ]
 }
-
diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRuleHelpers.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReduceIntoInsteadOfLoopRuleHelpers.swift
@@ -5,7 +5,7 @@ struct ReduceIntoInsteadOfLoopRuleHelpers { }
 extension VariableDeclSyntax {
     /// Binding is a var: "`var` someVar = <...>"
     var isVar: Bool {
-        return self.bindingSpecifier.tokenKind == .keyword(.var)
+        self.bindingSpecifier.tokenKind == .keyword(.var)
     }
 
     var identifier: String? {
@@ -20,7 +20,7 @@ extension VariableDeclSyntax {
     /// `type`.
     func firstPatternOf<T: PatternSyntaxProtocol>(_ type: T.Type) -> T? {
         let result = self.bindings.first { patternBinding in
-            return patternBinding.pattern.as(type) != nil
+            patternBinding.pattern.as(type) != nil
         }
         return result?.pattern.as(type)
     }