@fromanirh: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

/sig node
/good-first-issue
/help

@fromanirh:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

@endocrimes @SergeyKanzhelev I think this can help us as tracking issue and to involve more contributors

@prakharporwal I think this can be a very nice way to start contributing in the node area (xref: #109595 (comment))

Sure can you assign this to me will start working on this.

/assign

/assign @prakharporwal

Hi @fromanirh, @prakharporwal I am also interested in this issue, and I saw that there several sub-tasks. Maybe I could also participate in resolving this?

@STRRL hi! Indeed there are several subtasks and I think there is ample space for collaboration.

/assign

Hi ! Sure @STRRL. I am working on

• k/k/pkg/kubelet/cm/internal_container_lifecycle.go
• k/k/pkg/kubelet/cm/internal_container_lifecycle_linux.go
  right now.

@fromanirh I raised a draft PR please you take a look. I created 1 test for internal container lifecycle PreStartContainer. I am a little confused onto what to assert on once the PreStartContainer function runs. What will change when this function runs ? What do we want to test for ?

Hi ! Sure @STRRL. I am working on

k/k/pkg/kubelet/cm/internal_container_lifecycle.go
k/k/pkg/kubelet/cm/internal_container_lifecycle_linux.go
right now.

I would take a look at the rest files. :)

Hi @fromanirh, @prakharporwal, @STRRL I am also interested in this issue, and I saw that there several sub-tasks. Maybe I could also participate in resolving this?

l

Hi @prakharporwal @STRRL @yuv00191

• k/k/pkg/kubelet/cm/qos_container_manager_linux.go

If no one is working it yet, can I do the work related to that?

/assign

@JayKayy this may have some room for another contributor, if you're interested.

@JayKayy this may have some room for another contributor, if you're interested.

To give readers more context: basically any go source code with missing or insufficient unit test coverage is a good candidate. Some source files are harder than others to unit-test, and we will probably need to create or improve mocks/fakes. But we should start this process anyway, so totally help is welcome in this area.

Sure I would like to get involved. I start looking at the coverage

@21kyu @yuv00191 . I think their is scope as the creator mentioned. You can pick up as per what you find. I am not working on

• k/k/pkg/kubelet/cm/qos_container_manager_linux.go
  You can take it up.

/assign

/assign

@fromanirh @endocrimes I am trying to mock the the cpumanager NewManager ( memory and topology also ) . I generated the mock file using mockgen. but I get this error when I run my test. Can you take a look and help. I have looked at multiple places on internet none of it is making sense to me.

@21kyu @STRRL @JayKayy @yuv00191 Any Ideas.

Went through these. not helping.

golang/mock#428
https://stackoverflow.com/questions/68794050/gomock-missing-calls

Link to my PR : #109746

@fromanirh @endocrimes I am trying to mock the the cpumanager NewManager ( memory and topology also ) . I generated the mock file using mockgen. but I get this error when I run my test. Can you take a look and help. I have looked at multiple places on internet none of it is making sense to me.
...

Hello @prakharporwal!
I commented on your PR #109746.

I want to work on it.
I want to work on k/k/pkg/kubelet/cm/cgroup_manager_linux.go because it doesn't seem to have enough coverage.

/assign

/assign

Hello all. I'm looking to begin contributing to this project and I saw this designated as good first issue. Before I dive in, is it safe to begin looking at coverage for pod_manager.go or is someone else investigating?